Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algorithms description framework. May still need tweaking. #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsoules
Copy link
Owner

@jsoules jsoules commented May 28, 2021

This is more of a draft PR since I haven't tested it all that thoroughly, but it appears to be generating the right HTML.

We add components that handle the Algorithms, as well as the Sidebar and Preload. I have not fished out all the ways in which the API is queried to provide the algorithm data payload; right now I am hosting that locally and loading it for the App homepage.

Wanted to put this forward and solicit feedback over the week I'm out.

@jsoules
Copy link
Owner Author

jsoules commented Jun 25, 2021

Added vercel link as demo: https://othismos-eueug8ixk-jsoules.vercel.app/

I've been hunting on this thing and still can't sort out what's different about how the CSS files are getting loaded (compared to production). I have confirmed that the generated HTML is identical for the relevant portions, however as seen in the demo, the sidebar is rendering off the page, and the first algorithm card is not getting the same styling applied as the others (despite, again, having no HTML differences from either the published version or the others in the list...)

In any event, I've put into this as much as I think is productive, so I'm going to move this PR out of draft status and assume we'll fix it later if it doesn't shake out later.

@jsoules jsoules marked this pull request as ready for review June 25, 2021 19:06
This was referenced Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant